From: Stefan Krah <stefan@bytereef.org>
Date: Sat, 17 Jul 2010 12:21:08 +0000 (+0000)
Subject: Issue #7384: On Gentoo, libreadline.so is a "fake library", so ldd fails.
X-Git-Tag: v2.7.1rc1~592
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=2e26e23d9df202fa2314b57530e5af32ff326e5b;p=python

Issue #7384: On Gentoo, libreadline.so is a "fake library", so ldd fails.
In that case, do not attempt to parse stderr output.
---

diff --git a/setup.py b/setup.py
index 464242d5c1..a363509fbd 100644
--- a/setup.py
+++ b/setup.py
@@ -594,16 +594,18 @@ class PyBuildExt(build_ext):
         # Determine if readline is already linked against curses or tinfo.
         if do_readline and find_executable('ldd'):
             fp = os.popen("ldd %s" % do_readline)
-            for ln in fp:
-                if 'curses' in ln:
-                    readline_termcap_library = re.sub(
-                        r'.*lib(n?cursesw?)\.so.*', r'\1', ln
-                    ).rstrip()
-                    break
-                if 'tinfo' in ln: # termcap interface split out from ncurses
-                    readline_termcap_library = 'tinfo'
-                    break
-            fp.close()
+            ldd_output = fp.readlines()
+            ret = fp.close()
+            if ret is None or ret >> 8 == 0:
+                for ln in ldd_output:
+                    if 'curses' in ln:
+                        readline_termcap_library = re.sub(
+                            r'.*lib(n?cursesw?)\.so.*', r'\1', ln
+                        ).rstrip()
+                        break
+                    if 'tinfo' in ln: # termcap interface split out from ncurses
+                        readline_termcap_library = 'tinfo'
+                        break
         # Issue 7384: If readline is already linked against curses,
         # use the same library for the readline and curses modules.
         if 'curses' in readline_termcap_library: