From: Christian Heimes <christian@python.org>
Date: Tue, 30 Jan 2018 07:55:46 +0000 (+0100)
Subject: bpo-28134: Ignore proto in unknown socket test (GH-5435)
X-Git-Tag: v3.7.0b1~8
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=2e0ecde8d74f5fc0e3e3e39216975cc70efc4796;p=python

bpo-28134: Ignore proto in unknown socket test (GH-5435)

Band-aid for macOS: Some platforms seem to ignore unknown protocols.

Signed-off-by: Christian Heimes <christian@python.org>
---

diff --git a/Lib/test/test_socket.py b/Lib/test/test_socket.py
index 89cf1fa520..2851922bd0 100644
--- a/Lib/test/test_socket.py
+++ b/Lib/test/test_socket.py
@@ -1618,7 +1618,7 @@ class GeneralModuleTests(unittest.TestCase):
             self.assertEqual(s.type, socket.SOCK_STREAM)
 
     @unittest.skipIf(os.name == 'nt', 'Will not work on Windows')
-    def test_uknown_socket_family_repr(self):
+    def test_unknown_socket_family_repr(self):
         # Test that when created with a family that's not one of the known
         # AF_*/SOCK_* constants, socket.family just returns the number.
         #
@@ -1642,7 +1642,8 @@ class GeneralModuleTests(unittest.TestCase):
                 fileno=fd) as s:
             self.assertEqual(s.family, unknown_family)
             self.assertEqual(s.type, unknown_type)
-            self.assertEqual(s.proto, 23)
+            # some OS like macOS ignore proto
+            self.assertIn(s.proto, {0, 23})
 
     @unittest.skipUnless(hasattr(os, 'sendfile'), 'test needs os.sendfile()')
     def test__sendfile_use_sendfile(self):