From: Steve Holme <steve_holme@hotmail.com>
Date: Fri, 15 Feb 2013 18:33:28 +0000 (+0000)
Subject: pop3: Removed unnecessary state changes on failure
X-Git-Tag: curl-7_30_0~340
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=2dbeaf7dad4f6659c9887970cc5b914c6f19d323;p=curl

pop3: Removed unnecessary state changes on failure
---

diff --git a/lib/pop3.c b/lib/pop3.c
index b94f6f7e4..d2d49fecc 100644
--- a/lib/pop3.c
+++ b/lib/pop3.c
@@ -977,9 +977,9 @@ static CURLcode pop3_state_auth_final_resp(struct connectdata *conn,
     failf(data, "Authentication failed: %d", pop3code);
     result = CURLE_LOGIN_DENIED;
   }
-
-  /* End of connect phase */
-  state(conn, POP3_STOP);
+  else
+    /* End of connect phase */
+    state(conn, POP3_STOP);
 
   return result;
 }
@@ -997,9 +997,9 @@ static CURLcode pop3_state_apop_resp(struct connectdata *conn, int pop3code,
     failf(data, "Authentication failed: %d", pop3code);
     result = CURLE_LOGIN_DENIED;
   }
-
-  /* End of connect phase */
-  state(conn, POP3_STOP);
+  else
+    /* End of connect phase */
+    state(conn, POP3_STOP);
 
   return result;
 }
@@ -1044,9 +1044,9 @@ static CURLcode pop3_state_pass_resp(struct connectdata *conn, int pop3code,
     failf(data, "Access denied. %c", pop3code);
     result = CURLE_LOGIN_DENIED;
   }
-
-  /* End of connect phase */
-  state(conn, POP3_STOP);
+  else
+    /* End of connect phase */
+    state(conn, POP3_STOP);
 
   return result;
 }