From: Christoph M. Becker <cmbecker69@gmx.de>
Date: Fri, 16 Aug 2019 15:46:46 +0000 (+0200)
Subject: Don't explicitly set return value on ZPP failure
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=2d1f371871ef5afee6b2d683c760b25c8b147c66;p=php

Don't explicitly set return value on ZPP failure

Failing ZPP throws as of PHP 8.0.0, so explicitly setting a return
value is useless, and also slightly confusing.
---

diff --git a/ext/bz2/bz2.c b/ext/bz2/bz2.c
index bf706f6449..b4079df5d5 100644
--- a/ext/bz2/bz2.c
+++ b/ext/bz2/bz2.c
@@ -335,7 +335,7 @@ static PHP_FUNCTION(bzread)
 	zend_string *data;
 
 	if (FAILURE == zend_parse_parameters(ZEND_NUM_ARGS(), "r|l", &bz, &len)) {
-		RETURN_FALSE;
+		return;
 	}
 
 	php_stream_from_zval(stream, bz);
@@ -535,7 +535,7 @@ static PHP_FUNCTION(bzdecompress)
 	bz_stream bzs;
 
 	if (FAILURE == zend_parse_parameters(ZEND_NUM_ARGS(), "s|l", &source, &source_len, &small)) {
-		RETURN_FALSE;
+		return;
 	}
 
 	bzs.bzalloc = NULL;