From: Sjoerd Meijer <sjoerd.meijer@arm.com>
Date: Mon, 24 Jun 2019 08:44:29 +0000 (+0000)
Subject: Follow up of rL363913. NFC.
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=2c64704a921f6a3766f95aba4ad3cb3a76d6d960;p=llvm

Follow up of rL363913. NFC.

Minor reshuffle in AArch64 targetparser unittest, solving a potential problem
with querying iterators too early.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@364168 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/unittests/Support/TargetParserTest.cpp b/unittests/Support/TargetParserTest.cpp
index 5cffbe98493..b11d9ae7f00 100644
--- a/unittests/Support/TargetParserTest.cpp
+++ b/unittests/Support/TargetParserTest.cpp
@@ -1053,16 +1053,18 @@ TEST(TargetParserTest, AArch64ExtensionFeatures) {
   std::vector<StringRef> Features;
 
   unsigned ExtVal = 0;
-  for (auto E : Extensions)
-    ExtVal |= E;
+  for (auto Ext : Extensions)
+    ExtVal |= Ext;
+
+  EXPECT_FALSE(AArch64::getExtensionFeatures(AArch64::AEK_INVALID, Features));
+  EXPECT_TRUE(!Features.size());
 
   AArch64::getExtensionFeatures(ExtVal, Features);
+  EXPECT_TRUE(Extensions.size() == Features.size());
+
   auto B = std::begin(Features);
   auto E = std::end(Features);
 
-  EXPECT_FALSE(AArch64::getExtensionFeatures(AArch64::AEK_INVALID, Features));
-  EXPECT_TRUE(Extensions.size() == Features.size());
-
   EXPECT_TRUE(std::find(B, E, "+crc") != E);
   EXPECT_TRUE(std::find(B, E, "+crypto") != E);
   EXPECT_TRUE(std::find(B, E, "+fp-armv8") != E);