From: Aki Tuomi Date: Sat, 26 Oct 2013 19:21:07 +0000 (+0300) Subject: Unit test for empty lookup/list result X-Git-Tag: rec-3.6.0-rc1~374^2 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=2be5f2577c98355c33744affcdc1b68d48312a62;p=pdns Unit test for empty lookup/list result --- diff --git a/modules/remotebackend/test-remotebackend.cc b/modules/remotebackend/test-remotebackend.cc index 0dcfd9b66..f06f193e6 100644 --- a/modules/remotebackend/test-remotebackend.cc +++ b/modules/remotebackend/test-remotebackend.cc @@ -39,6 +39,14 @@ BOOST_AUTO_TEST_CASE(test_method_lookup) { BOOST_CHECK_EQUAL(rr.ttl, 300); } +BOOST_AUTO_TEST_CASE(test_method_lookup_empty) { + BOOST_TEST_MESSAGE("Testing lookup method with empty result"); + DNSResourceRecord rr; + be->lookup(QType(QType::SOA), "empty.unit.test"); + // then try to get() + BOOST_CHECK(!be->get(rr)); // and this should be FALSE +} + BOOST_AUTO_TEST_CASE(test_method_list) { int record_count = 0; DNSResourceRecord rr; diff --git a/modules/remotebackend/unittest.rb b/modules/remotebackend/unittest.rb index d806da320..c44cf98dd 100644 --- a/modules/remotebackend/unittest.rb +++ b/modules/remotebackend/unittest.rb @@ -16,7 +16,8 @@ $domain = { }, "ns2.unit.test" => { "A" => ["10.0.0.2"] - } + }, + "empty.unit.test" => {} } $meta = {} @@ -52,7 +53,7 @@ class Handler end end end - [false] unless ret.size>0 + [false] unless ret.size>0 and args["qname"] != "empty.unit.test" [ret] end