From: Chris Lattner <sabre@nondot.org>
Date: Thu, 20 Nov 2008 05:41:43 +0000 (+0000)
Subject: remove some other identifiers that are looked up really early and only
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=2bac0f6b3724734d7bb7bf8231bd8511cb49570f;p=clang

remove some other identifiers that are looked up really early and only
used in one cold place.


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@59709 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Sema/Sema.cpp b/lib/Sema/Sema.cpp
index dcb3af31b0..2b33bf4046 100644
--- a/lib/Sema/Sema.cpp
+++ b/lib/Sema/Sema.cpp
@@ -103,12 +103,6 @@ Sema::Sema(Preprocessor &pp, ASTContext &ctxt, ASTConsumer &consumer)
   KnownFunctionIDs[id_vsnprintf_chk] = &IT.get("__builtin___vsnprintf_chk");
   KnownFunctionIDs[id_vprintf]       = &IT.get("vprintf");
 
-  // ObjC builtin typedef names.
-  Ident_id = &IT.get("id");
-  Ident_Class = &IT.get("Class");
-  Ident_SEL = &IT.get("SEL");
-  Ident_Protocol = &IT.get("Protocol");
-
   Ident_StdNs = &IT.get("std");
   Ident_TypeInfo = 0;
   StdNamespace = 0;
diff --git a/lib/Sema/Sema.h b/lib/Sema/Sema.h
index db75513b1a..ab465247c8 100644
--- a/lib/Sema/Sema.h
+++ b/lib/Sema/Sema.h
@@ -192,10 +192,6 @@ public:
   /// This list is populated upon the creation of a Sema object.    
   IdentifierInfo* KnownFunctionIDs[id_num_known_functions];
 
-  /// Identifiers for builtin ObjC typedef names.
-  IdentifierInfo *Ident_id, *Ident_Class;     // "id", "Class"
-  IdentifierInfo *Ident_SEL, *Ident_Protocol; // "SEL", "Protocol"
-
   /// Identifiers used by the C++ language
   IdentifierInfo *Ident_StdNs; // "std"
   IdentifierInfo *Ident_TypeInfo; // "type_info" - lazily created
diff --git a/lib/Sema/SemaDecl.cpp b/lib/Sema/SemaDecl.cpp
index 941f40fa52..e7a9c0ee72 100644
--- a/lib/Sema/SemaDecl.cpp
+++ b/lib/Sema/SemaDecl.cpp
@@ -294,17 +294,27 @@ TypedefDecl *Sema::MergeTypeDefDecl(TypedefDecl *New, Decl *OldD) {
   // Allow multiple definitions for ObjC built-in typedefs.
   // FIXME: Verify the underlying types are equivalent!
   if (getLangOptions().ObjC1) {
-    const IdentifierInfo *typeIdent = New->getIdentifier();
-    if (typeIdent == Ident_id) {
+    const IdentifierInfo *TypeID = New->getIdentifier();
+    switch (TypeID->getLength()) {
+    default: break;
+    case 2: 
+      if (!TypeID->isStr("id"))
+        break;
       Context.setObjCIdType(New);
       return New;
-    } else if (typeIdent == Ident_Class) {
+    case 5:
+      if (!TypeID->isStr("Class"))
+        break;
       Context.setObjCClassType(New);
       return New;
-    } else if (typeIdent == Ident_SEL) {
+    case 3:
+      if (!TypeID->isStr("SEL"))
+        break;
       Context.setObjCSelType(New);
       return New;
-    } else if (typeIdent == Ident_Protocol) {
+    case 8:
+      if (!TypeID->isStr("Protocol"))
+        break;
       Context.setObjCProtoType(New->getUnderlyingType());
       return New;
     }