From: Matthew Fernandez Date: Sat, 13 Nov 2021 01:32:47 +0000 (-0800) Subject: xdot_gradient_fillcolor: remove dead store to 'r1' X-Git-Tag: 2.50.0~32^2~12 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=2b720b83b2b9bc0338d48372216a81bf7a1f9806;p=graphviz xdot_gradient_fillcolor: remove dead store to 'r1' This variable is overwritten on line 648 without having been read in between. This code appears copy-pasted from `cairo_gradient_fill` without noticing that this line is unused here. --- diff --git a/plugin/core/gvrender_core_dot.c b/plugin/core/gvrender_core_dot.c index 8eb43e2d8..cc71d140c 100644 --- a/plugin/core/gvrender_core_dot.c +++ b/plugin/core/gvrender_core_dot.c @@ -632,8 +632,7 @@ static void xdot_gradient_fillcolor (GVJ_t* job, int filled, pointf* A, int n) } else { get_gradient_points(A, G, n, 0, 3); - //r1 is inner radius, r2 is outer radius - r1 = G[1].x; + // r2 is outer radius r2 = G[1].y; if (angle == 0) { c1.x = G[0].x;