From: Senthil Kumaran Date: Tue, 19 Mar 2013 23:11:07 +0000 (-0700) Subject: #17471 - Increasing the urllib.error test coverage. Bringing it to 100%. Based on... X-Git-Tag: v3.2.4rc1~16 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=2a4d24510ad120b492afd63e60a6f8060556897c;p=python #17471 - Increasing the urllib.error test coverage. Bringing it to 100%. Based on patch contributed by Daniel Wozniak --- diff --git a/Lib/test/test_urllib2.py b/Lib/test/test_urllib2.py index a9776ac857..70fbb64f55 100644 --- a/Lib/test/test_urllib2.py +++ b/Lib/test/test_urllib2.py @@ -1446,10 +1446,18 @@ class RequestTests(unittest.TestCase): Issue 13211 reveals that HTTPError didn't implement the URLError interface even though HTTPError is a subclass of URLError. - >>> err = urllib.error.HTTPError(msg='something bad happened', url=None, code=None, hdrs=None, fp=None) + >>> msg = 'something bad happened' + >>> url = code = fp = None + >>> hdrs = 'Content-Length: 42' + >>> err = urllib.error.HTTPError(url, code, msg, hdrs, fp) >>> assert hasattr(err, 'reason') >>> err.reason 'something bad happened' + >>> assert hasattr(err, 'hdrs') + >>> err.hdrs + 'Content-Length: 42' + >>> expected_errmsg = 'HTTP Error %s: %s' % (err.code, err.msg) + >>> assert str(err) == expected_errmsg """ def test_HTTPError_interface_call(self):