From: Ehsan Akhgari <ehsan.akhgari@gmail.com>
Date: Mon, 22 Sep 2014 19:46:39 +0000 (+0000)
Subject: Return true from UnifySection when emitting a diagnostic
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=29f20ee56ca16b27eb1a2f8568b59561aa5f0fc3;p=clang

Return true from UnifySection when emitting a diagnostic

Test Plan: I noticed this through code inspection.  The callers use the return value to remove the SectionAttr if a diagnostic is emitted, but I don't think the failure to do so is observable right now.

Reviewers: rnk

Subscribers: cfe-commits

Differential Revision: http://reviews.llvm.org/D5438

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@218265 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Sema/SemaAttr.cpp b/lib/Sema/SemaAttr.cpp
index 6320faab37..f92bb68d20 100644
--- a/lib/Sema/SemaAttr.cpp
+++ b/lib/Sema/SemaAttr.cpp
@@ -384,7 +384,7 @@ bool Sema::UnifySection(StringRef SectionName,
   if (auto A = OtherDecl->getAttr<SectionAttr>())
     if (A->isImplicit())
       Diag(A->getLocation(), diag::note_pragma_entered_here);
-  return false;
+  return true;
 }
 
 bool Sema::UnifySection(StringRef SectionName,