From: Antony Dovgal <tony2001@php.net>
Date: Thu, 1 Jun 2006 11:56:44 +0000 (+0000)
Subject: MFH: throw a warning when using invalid offset types with strings
X-Git-Tag: php-5.2.0RC1~396
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=29be5946f9b0b10f85ca28aa69c64a7bd275bed3;p=php

MFH: throw a warning when using invalid offset types with strings
---

diff --git a/Zend/zend_execute.c b/Zend/zend_execute.c
index 2c4a457a70..f7a19a5845 100644
--- a/Zend/zend_execute.c
+++ b/Zend/zend_execute.c
@@ -1016,6 +1016,19 @@ static void zend_fetch_dimension_address(temp_variable *result, zval **container
 				}
 
 				if (Z_TYPE_P(dim) != IS_LONG) {
+					switch(Z_TYPE_P(dim)) {
+						/* case IS_LONG: */
+						case IS_STRING:
+						case IS_DOUBLE:
+						case IS_NULL:
+						case IS_BOOL:
+							/* do nothing */
+							break;
+						default:
+							zend_error(E_WARNING, "Illegal offset type");
+							break;
+					}
+
 					tmp = *dim;
 					zval_copy_ctor(&tmp);
 					convert_to_long(&tmp);