From: Teodor Sigaev <teodor@sigaev.ru>
Date: Tue, 10 Apr 2018 11:58:46 +0000 (+0300)
Subject: Remove wrongly backpatched piece of code in cube.c
X-Git-Tag: REL_10_4~42
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=29ab1567e7ea4dccac75b60db3840db6f8859e40;p=postgresql

Remove wrongly backpatched piece of code in cube.c

Due to sloppy division of changes between f50c80dbb (which was not
back-patched) and 563a053bd, this piece of code was wrongly backpatched to
REL_10_STABLE and REL9_6_STABLE.  This code never causes real error because
its condition is never satisfied, but it's a dead code, which needs to be
removed.

Alexander Korotkov per gripe from Tom Lane
---

diff --git a/contrib/cube/cube.c b/contrib/cube/cube.c
index e695a5e16c..3df4fa32ca 100644
--- a/contrib/cube/cube.c
+++ b/contrib/cube/cube.c
@@ -1555,7 +1555,6 @@ cube_coord_llur(PG_FUNCTION_ARGS)
 {
 	NDBOX	   *cube = PG_GETARG_NDBOX(0);
 	int			coord = PG_GETARG_INT32(1);
-	bool		inverse = false;
 	float8		result;
 
 	/* 0 is the only unsupported coordinate value */
@@ -1593,10 +1592,6 @@ cube_coord_llur(PG_FUNCTION_ARGS)
 		result = 0.0;
 	}
 
-	/* Inverse value if needed */
-	if (inverse)
-		result = -result;
-
 	PG_RETURN_FLOAT8(result);
 }