From: Eugene Syromyatnikov <evgsyr@gmail.com>
Date: Sun, 1 Jan 2017 19:40:34 +0000 (+0300)
Subject: loop: remove unnecessary verbose check
X-Git-Tag: v4.16~99
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=297f570c2d9595fb6a3eb50ca07774dcae110e5d;p=strace

loop: remove unnecessary verbose check

The verbose flag is responsible for dereferencing of addresses, and it
is perfectly handled by umove_or_printaddr; moreover, this early exit
leads to incorrect formatting of last argument.

* loop.c (loop_ioctl): Do not check verbose flag explicitly and do not
exit early if it is not set.
---

diff --git a/loop.c b/loop.c
index 20e080ff..f19ad928 100644
--- a/loop.c
+++ b/loop.c
@@ -160,9 +160,6 @@ MPERS_PRINTER_DECL(int, loop_ioctl,
 		   struct tcb *tcp, const unsigned int code,
 		   const kernel_ulong_t arg)
 {
-	if (!verbose(tcp))
-		return RVAL_DECODED;
-
 	switch (code) {
 	case LOOP_GET_STATUS:
 		if (entering(tcp))