From: sr55 Date: Sun, 6 May 2018 12:44:35 +0000 (+0100) Subject: WinGui: For MP4 files, when subtitles are incompatible and we've already used a burn... X-Git-Tag: 1.2.0~494 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=292f660b2f9e10569d9ca0eba6095cc02fd7d1a4;p=handbrake WinGui: For MP4 files, when subtitles are incompatible and we've already used a burn-in track, drop all additional subtitle tracks instead of adding them. --- diff --git a/win/CS/HandBrakeWPF/ViewModels/SubtitlesViewModel.cs b/win/CS/HandBrakeWPF/ViewModels/SubtitlesViewModel.cs index bc8ba1ce2..7b090841c 100644 --- a/win/CS/HandBrakeWPF/ViewModels/SubtitlesViewModel.cs +++ b/win/CS/HandBrakeWPF/ViewModels/SubtitlesViewModel.cs @@ -594,6 +594,11 @@ namespace HandBrakeWPF.ViewModels // For MP4, PGS Subtitles must be burned in. if (!track.Burned && (source.SubtitleType == SubtitleType.PGS) && this.Task != null && this.Task.OutputFormat == OutputFormat.Mp4) { + if (this.Task.SubtitleTracks.Any(a => a.Burned)) + { + return; // We can't add any more burned in tracks. + } + if (track.CanBeBurned) { track.Burned = true;