From: Todd C. Miller <Todd.Miller@courtesan.com>
Date: Tue, 22 Jul 2014 20:53:15 +0000 (-0600)
Subject: Fix NULL deref if base64_decode returns -1.
X-Git-Tag: SUDO_1_8_11^2~104
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=28f6ee5f9ef96dc5f9d4a60594484ea16b48cd10;p=sudo

Fix NULL deref if base64_decode returns -1.
---

diff --git a/plugins/sudoers/ldap.c b/plugins/sudoers/ldap.c
index cd8398ef4..1c0990652 100644
--- a/plugins/sudoers/ldap.c
+++ b/plugins/sudoers/ldap.c
@@ -1403,8 +1403,9 @@ sudo_ldap_decode_secret(const char *secret)
 	if (len == (size_t)-1) {
 	    free(result);
 	    result = NULL;
+	} else {
+	    result[len] = '\0';
 	}
-	result[len] = '\0';
     }
     debug_return_str((char *)result);
 }