From: Raymond Hettinger Date: Fri, 14 Aug 2015 09:07:41 +0000 (-0700) Subject: Minor cleanup. X-Git-Tag: v3.6.0a1~1792 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=28c995d03b6e2f5a77c42a97e95368767846f14f;p=python Minor cleanup. --- diff --git a/Modules/_collectionsmodule.c b/Modules/_collectionsmodule.c index 749cf6b31d..35034a50aa 100644 --- a/Modules/_collectionsmodule.c +++ b/Modules/_collectionsmodule.c @@ -2167,13 +2167,13 @@ _count_elements(PyObject *self, PyObject *args) oldval = _PyDict_GetItem_KnownHash(mapping, key, hash); if (oldval == NULL) { - if (_PyDict_SetItem_KnownHash(mapping, key, one, hash) == -1) + if (_PyDict_SetItem_KnownHash(mapping, key, one, hash) < 0) goto done; } else { newval = PyNumber_Add(oldval, one); if (newval == NULL) goto done; - if (_PyDict_SetItem_KnownHash(mapping, key, newval, hash) == -1) + if (_PyDict_SetItem_KnownHash(mapping, key, newval, hash) < 0) goto done; Py_CLEAR(newval); } @@ -2199,7 +2199,7 @@ _count_elements(PyObject *self, PyObject *args) Py_DECREF(oldval); if (newval == NULL) break; - if (PyObject_SetItem(mapping, key, newval) == -1) + if (PyObject_SetItem(mapping, key, newval) < 0) break; Py_CLEAR(newval); Py_DECREF(key);