From: Matthew Fernandez <matthew.fernandez@gmail.com>
Date: Wed, 24 Feb 2021 01:56:03 +0000 (-0800)
Subject: remove strncmp micro-optimization in rindexOf
X-Git-Tag: 2.47.0~17^2~15
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=28b9672cae20858422771dff99ad955c04237095;p=graphviz

remove strncmp micro-optimization in rindexOf

Compilers can do this trick themselves if they decide there is speed to be
gained from it.
---

diff --git a/lib/gvpr/actions.c b/lib/gvpr/actions.c
index 7b7566e94..4d3293a42 100644
--- a/lib/gvpr/actions.c
+++ b/lib/gvpr/actions.c
@@ -65,7 +65,6 @@ int indexOf(char *s1, char *s2)
 int rindexOf(char *s1, char *s2)
 {
     char c1 = *s2;
-    char c;
     char *p;
     size_t len1 = strlen(s1);
     size_t len2 = strlen(s2);
@@ -76,8 +75,7 @@ int rindexOf(char *s1, char *s2)
 	return -1;
     p = s1 + (len1 - len2);
     while (p >= s1) {
-	c = *p;
-	if ((c == c1) && (strncmp(p+1, s2+1, len2-1) == 0))
+	if (strncmp(p, s2, len2) == 0)
 	    return (p - s1);
 	else
 	    p--;