From: Moriyoshi Koizumi <moriyoshi@php.net>
Date: Mon, 30 Dec 2002 13:56:28 +0000 (+0000)
Subject: MFH: Ilia's patch for bug #21268 (session_decode() returned FALSE on success)
X-Git-Tag: PHP_4_3_before_13561_fix~166
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=28624bb7f60d5ab1e87e85f61efaf9624e83fc10;p=php

MFH: Ilia's patch for bug #21268 (session_decode() returned FALSE on success)
---

diff --git a/ext/session/session.c b/ext/session/session.c
index 8b6be415ab..2af454d622 100644
--- a/ext/session/session.c
+++ b/ext/session/session.c
@@ -1433,15 +1433,19 @@ PHP_FUNCTION(session_decode)
 {
 	zval **str;
 
-	if (ZEND_NUM_ARGS() != 1 || zend_get_parameters_ex(1, &str) == FAILURE)
+	if (ZEND_NUM_ARGS() != 1 || zend_get_parameters_ex(1, &str) == FAILURE) {
 		WRONG_PARAM_COUNT;
+	}
 
-	if (PS(session_status) == php_session_none)
+	if (PS(session_status) == php_session_none) {
 		RETURN_FALSE;
+	}
 
 	convert_to_string_ex(str);
 
 	php_session_decode(Z_STRVAL_PP(str), Z_STRLEN_PP(str) TSRMLS_CC);
+
+	RETURN_TRUE;
 }
 /* }}} */