From: Ziang Wan Date: Thu, 1 Aug 2019 01:39:21 +0000 (+0000) Subject: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision... X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=281e7e161d059513eb14c73e4acc5c650a2d2fbc;p=clang [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss Fix one test case for it to be system-independent. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@367502 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/test/Sema/implicit-int-float-conversion.c b/test/Sema/implicit-int-float-conversion.c index 0933cd9351..b8c29d2d45 100644 --- a/test/Sema/implicit-int-float-conversion.c +++ b/test/Sema/implicit-int-float-conversion.c @@ -8,13 +8,8 @@ void testAssignment() { float f = 222222; double b = 222222222222L; -#ifndef __ILP32__ - float ff = 222222222222L; // expected-warning {{implicit conversion from 'long' to 'float' changes value from 222222222222 to 222222221312}} - float ffff = 222222222222UL; // expected-warning {{implicit conversion from 'unsigned long' to 'float' changes value from 222222222222 to 222222221312}} -#else - float ff = 222222222222L; // expected-warning {{implicit conversion from 'long long' to 'float' changes value from 222222222222 to 222222221312}} - float ffff = 222222222222UL; // expected-warning {{implicit conversion from 'unsigned long long' to 'float' changes value from 222222222222 to 222222221312}} -#endif + float ff = 222222222222L; // expected-warning {{changes value from 222222222222 to 222222221312}} + float ffff = 222222222222UL; // expected-warning {{changes value from 222222222222 to 222222221312}} long l = 222222222222L; float fff = l; // expected-warning {{implicit conversion from 'long' to 'float' may lose precision}} @@ -23,11 +18,7 @@ void testAssignment() { void testExpression() { float a = 0.0f; -#ifndef __ILP32__ - float b = 222222222222L + a; // expected-warning {{implicit conversion from 'long' to 'float' changes value from 222222222222 to 222222221312}} -#else - float b = 222222222222L + a; // expected-warning {{implicit conversion from 'long long' to 'float' changes value from 222222222222 to 222222221312}} -#endif + float b = 222222222222L + a; // expected-warning {{changes value from 222222222222 to 222222221312}} float g = 22222222 + 22222222; float c = 22222222 + 22222223; // expected-warning {{implicit conversion from 'int' to 'float' changes value from 44444445 to 44444444}} @@ -42,11 +33,7 @@ void testExpression() { void testCNarrowing() { // Since this is a C file. C++11 narrowing is not in effect. // In this case, we should issue warnings. -#ifndef __ILP32__ - float a = {222222222222L}; // expected-warning {{implicit conversion from 'long' to 'float' changes value from 222222222222 to 222222221312}} -#else - float a = {222222222222L}; // expected-warning {{implicit conversion from 'long long' to 'float' changes value from 222222222222 to 222222221312}} -#endif + float a = {222222222222L}; // expected-warning {{changes value from 222222222222 to 222222221312}} long b = 222222222222L; float c = {b}; // expected-warning {{implicit conversion from 'long' to 'float' may lose precision}}