From: Andrea Di Biagio Date: Fri, 13 Jul 2018 09:27:34 +0000 (+0000) Subject: [llvm-mca] Removed unused arguments from methods in class Pipeline. NFC X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=27babdf37a5890c2f27ba231a4acd29983187f4d;p=llvm [llvm-mca] Removed unused arguments from methods in class Pipeline. NFC git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@336983 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/tools/llvm-mca/Pipeline.cpp b/tools/llvm-mca/Pipeline.cpp index ebaacb27a9f..eb95b0c496f 100644 --- a/tools/llvm-mca/Pipeline.cpp +++ b/tools/llvm-mca/Pipeline.cpp @@ -58,13 +58,15 @@ void Pipeline::postExecuteStages(const InstRef &IR) { } void Pipeline::run() { - while (hasWorkToProcess()) - runCycle(Cycles++); + while (hasWorkToProcess()) { + notifyCycleBegin(); + runCycle(); + notifyCycleEnd(); + ++Cycles; + } } -void Pipeline::runCycle(unsigned Cycle) { - notifyCycleBegin(Cycle); - +void Pipeline::runCycle() { // Update the stages before we do any processing for this cycle. InstRef IR; for (auto &S : Stages) @@ -81,18 +83,16 @@ void Pipeline::runCycle(unsigned Cycle) { for (auto &S : Stages) S->cycleEnd(); - - notifyCycleEnd(Cycle); } -void Pipeline::notifyCycleBegin(unsigned Cycle) { - LLVM_DEBUG(dbgs() << "[E] Cycle begin: " << Cycle << '\n'); +void Pipeline::notifyCycleBegin() { + LLVM_DEBUG(dbgs() << "[E] Cycle begin: " << Cycles << '\n'); for (HWEventListener *Listener : Listeners) Listener->onCycleBegin(); } -void Pipeline::notifyCycleEnd(unsigned Cycle) { - LLVM_DEBUG(dbgs() << "[E] Cycle end: " << Cycle << "\n\n"); +void Pipeline::notifyCycleEnd() { + LLVM_DEBUG(dbgs() << "[E] Cycle end: " << Cycles << "\n\n"); for (HWEventListener *Listener : Listeners) Listener->onCycleEnd(); } diff --git a/tools/llvm-mca/Pipeline.h b/tools/llvm-mca/Pipeline.h index 888d9c9d368..ca355784b1e 100644 --- a/tools/llvm-mca/Pipeline.h +++ b/tools/llvm-mca/Pipeline.h @@ -62,8 +62,11 @@ class Pipeline { void preExecuteStages(const InstRef &IR); bool executeStages(InstRef &IR); void postExecuteStages(const InstRef &IR); + void runCycle(); + bool hasWorkToProcess(); - void runCycle(unsigned Cycle); + void notifyCycleBegin(); + void notifyCycleEnd(); public: Pipeline(unsigned DispatchWidth = 0, unsigned RegisterFileSize = 0, @@ -73,8 +76,6 @@ public: void appendStage(std::unique_ptr S) { Stages.push_back(std::move(S)); } void run(); void addEventListener(HWEventListener *Listener); - void notifyCycleBegin(unsigned Cycle); - void notifyCycleEnd(unsigned Cycle); }; } // namespace mca