From: Norman Walsh <ndw@nwalsh.com>
Date: Fri, 25 Jan 2002 15:04:39 +0000 (+0000)
Subject: Fix bug that caused rowsep and colsep to be ignored on empty cells
X-Git-Tag: release/1.79.1~6^2~5954
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=2725b2b469eca38260355dac96f6cf820b6dbe24;p=docbook-dsssl

Fix bug that caused rowsep and colsep to be ignored on empty cells
---

diff --git a/xsl/common/table.xsl b/xsl/common/table.xsl
index 65f6fef20..01e969422 100644
--- a/xsl/common/table.xsl
+++ b/xsl/common/table.xsl
@@ -449,10 +449,10 @@ or 0 (the empty string)</para>
     <xsl:when test="$row.value != ''">
       <xsl:value-of select="$row.value"/>
     </xsl:when>
-    <xsl:when test="$span.value">
+    <xsl:when test="$span.value != ''">
       <xsl:value-of select="$span.value"/>
     </xsl:when>
-    <xsl:when test="$namest.value">
+    <xsl:when test="$namest.value != ''">
       <xsl:value-of select="$namest.value"/>
     </xsl:when>
     <xsl:when test="$colnum &gt; 0">
diff --git a/xsl/fo/table.xsl b/xsl/fo/table.xsl
index 69aa56ad6..488ffb288 100644
--- a/xsl/fo/table.xsl
+++ b/xsl/fo/table.xsl
@@ -61,6 +61,8 @@ to be incomplete. Don't forget to read the source, too :-)</para>
 <xsl:template name="empty.table.cell">
   <xsl:param name="colnum" select="0"/>
 
+  <xsl:variable name="frame" select="ancestor::tgroup/parent::*/@frame"/>
+
   <xsl:variable name="rowsep">
     <xsl:call-template name="inherited.table.attribute">
       <xsl:with-param name="entry" select="NOT-AN-ELEMENT-NAME"/>
@@ -80,25 +82,33 @@ to be incomplete. Don't forget to read the source, too :-)</para>
   <fo:table-cell text-align="center"
                  display-align="center"
                  padding="{$table.border.padding}">
-    <xsl:if test="$colsep &gt; 0">
-      <xsl:call-template name="border">
-        <xsl:with-param name="side" select="'right'"/>
-        <xsl:with-param name="padding" select="1"/>
-      </xsl:call-template>
-    </xsl:if>
-    <xsl:if test="$rowsep &gt; 0">
-      <xsl:call-template name="border">
-        <xsl:with-param name="side" select="'bottom'"/>
-        <xsl:with-param name="padding" select="1"/>
-      </xsl:call-template>
-    </xsl:if>
-    <fo:block>
-      <xsl:text>e(</xsl:text>
-      <xsl:value-of select="$rowsep"/>
-      <xsl:text>,</xsl:text>
-      <xsl:value-of select="$colsep"/>
-      <xsl:text>)</xsl:text>
-    </fo:block>
+    <xsl:choose>
+      <xsl:when test="$frame='all'">
+        <xsl:call-template name="border">
+          <xsl:with-param name="side" select="'right'"/>
+          <xsl:with-param name="padding" select="1"/>
+        </xsl:call-template>
+        <xsl:call-template name="border">
+          <xsl:with-param name="side" select="'bottom'"/>
+          <xsl:with-param name="padding" select="1"/>
+        </xsl:call-template>
+      </xsl:when>
+      <xsl:otherwise>
+        <xsl:if test="$colsep &gt; 0">
+          <xsl:call-template name="border">
+            <xsl:with-param name="side" select="'right'"/>
+            <xsl:with-param name="padding" select="1"/>
+          </xsl:call-template>
+        </xsl:if>
+        <xsl:if test="$rowsep &gt; 0">
+          <xsl:call-template name="border">
+            <xsl:with-param name="side" select="'bottom'"/>
+            <xsl:with-param name="padding" select="1"/>
+          </xsl:call-template>
+        </xsl:if>
+      </xsl:otherwise>
+    </xsl:choose>
+    <fo:block/> <!-- fo:table-cell should not be empty -->
   </fo:table-cell>
 </xsl:template>
 
@@ -211,7 +221,6 @@ to be incomplete. Don't forget to read the source, too :-)</para>
         </xsl:call-template>
       </xsl:with-param>
     </xsl:apply-templates>
-
   </fo:table-header>
 </xsl:template>
 
@@ -241,7 +250,6 @@ to be incomplete. Don't forget to read the source, too :-)</para>
         </xsl:call-template>
       </xsl:with-param>
     </xsl:apply-templates>
-
   </fo:table-body>
 </xsl:template>