From: Stefan Beller <sbeller@google.com>
Date: Wed, 27 Apr 2016 21:30:39 +0000 (-0700)
Subject: config.c: drop local variable
X-Git-Tag: v2.8.3~1^2~1
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=270cd9eaf459b94dee1836de9bf4382afebe1d7b;p=git

config.c: drop local variable

As `ret` is not used for anything except determining an early return,
we don't need a variable for that. Drop it.

Signed-off-by: Stefan Beller <sbeller@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/config.c b/config.c
index 03544e7a3f..84e437a9b9 100644
--- a/config.c
+++ b/config.c
@@ -1309,14 +1309,11 @@ static struct config_set_element *configset_find_element(struct config_set *cs,
 	struct config_set_element k;
 	struct config_set_element *found_entry;
 	char *normalized_key;
-	int ret;
 	/*
 	 * `key` may come from the user, so normalize it before using it
 	 * for querying entries from the hashmap.
 	 */
-	ret = git_config_parse_key(key, &normalized_key, NULL);
-
-	if (ret)
+	if (git_config_parse_key(key, &normalized_key, NULL))
 		return NULL;
 
 	hashmap_entry_init(&k, strhash(normalized_key));