From: Magnus Hagander Date: Thu, 16 Sep 2010 20:37:18 +0000 (+0000) Subject: Treat exit code 128 (ERROR_WAIT_NO_CHILDREN) as non-fatal on Win32, X-Git-Tag: REL8_3_12~4 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=26b01668cbd8bd1ad72b8eaca39f74323e5fbdc0;p=postgresql Treat exit code 128 (ERROR_WAIT_NO_CHILDREN) as non-fatal on Win32, since it can happen when a process fails to start when the system is under high load. Per several bug reports and many peoples investigation. Back-patch to 8.2, since testing shows no issues even though the "deadman-switch" does not exist in this version. --- diff --git a/src/backend/postmaster/postmaster.c b/src/backend/postmaster/postmaster.c index 5e705a36b4..bd0aeaf3aa 100644 --- a/src/backend/postmaster/postmaster.c +++ b/src/backend/postmaster/postmaster.c @@ -2338,6 +2338,19 @@ CleanupBackend(int pid, * assume everything is all right and simply remove the backend from the * active backend list. */ +#ifdef WIN32 + /* + * On win32, also treat ERROR_WAIT_NO_CHILDREN (128) as nonfatal + * case, since that sometimes happens under load when the process fails + * to start properly (long before it starts using shared memory). + */ + if (exitstatus == ERROR_WAIT_NO_CHILDREN) + { + LogChildExit(LOG, _("server process"), pid, exitstatus); + exitstatus = 0; + } +#endif + if (!EXIT_STATUS_0(exitstatus) && !EXIT_STATUS_1(exitstatus)) { HandleChildCrash(pid, exitstatus, _("server process"));