From: Dmitry Stogov <dmitry@zend.com>
Date: Wed, 28 Oct 2020 09:59:00 +0000 (+0300)
Subject: Don't force rebuild of symbol table, when populating $http_response_header variable... 
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=2693f799be862bcaddd4204c10fb1e82156bb603;p=php

Don't force rebuild of symbol table, when populating $http_response_header variable by the HTTP stream wrapper
---

diff --git a/NEWS b/NEWS
index 6030664f35..1c3eee1535 100644
--- a/NEWS
+++ b/NEWS
@@ -2,6 +2,10 @@ PHP                                                                        NEWS
 |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
 ?? ??? ????, PHP 8.0.0RC4
 
+- Standard:
+
+  . Don't force rebuild of symbol table, when populating $http_response_header
+    variable by the HTTP stream wrapper. (Dmitry)
 
 29 Oct 2020, PHP 8.0.0RC3
 
diff --git a/UPGRADING b/UPGRADING
index 1a270ba415..579424fbef 100644
--- a/UPGRADING
+++ b/UPGRADING
@@ -617,6 +617,8 @@ PHP 8.0 UPGRADE NOTES
   . substr(), mb_substr(), iconv_substr() and grapheme_substr() now consistently
     clamp out-of-bounds offsets to the string boundary. Previously, false was
     returned instead of the empty string in some cases.
+  . Populating $http_response_header variable by the HTTP stream wrapper
+    doesn't force rebuilding of symbol table anymore.
 
 - Sysvmsg:
   . msg_get_queue() will now return an SysvMessageQueue object rather than a
diff --git a/ext/standard/http_fopen_wrapper.c b/ext/standard/http_fopen_wrapper.c
index 50758ad0f4..d865d7e2f9 100644
--- a/ext/standard/http_fopen_wrapper.c
+++ b/ext/standard/http_fopen_wrapper.c
@@ -981,7 +981,7 @@ php_stream *php_stream_url_wrap_http(php_stream_wrapper *wrapper, const char *pa
 
 	if (!Z_ISUNDEF(headers)) {
 		if (FAILURE == zend_set_local_var_str(
-				"http_response_header", sizeof("http_response_header")-1, &headers, 1)) {
+				"http_response_header", sizeof("http_response_header")-1, &headers, 0)) {
 			zval_ptr_dtor(&headers);
 		}
 	}