From: Antony Dovgal <tony2001@php.net>
Date: Thu, 22 Jan 2004 08:05:14 +0000 (+0000)
Subject: MFB
X-Git-Tag: php_ibase_before_split~43
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=261726099c592e27bc6d4a5cd806f0e39fb49748;p=php

MFB
oci_lob_save() should be removed indeed, but we're already in feature freeze =(
---

diff --git a/ext/oci8/oci8.c b/ext/oci8/oci8.c
index 95d7e5f11f..669250180b 100644
--- a/ext/oci8/oci8.c
+++ b/ext/oci8/oci8.c
@@ -3842,8 +3842,8 @@ PHP_FUNCTION(oci_lob_save)
 
 			if (offparam == -1) {
 				offset = curloblen;
-			} else if ((ub4) offparam >= curloblen) {
-				php_error_docref(NULL TSRMLS_CC, E_WARNING, "Offset smaller than current LOB-Size - appending");
+			} else if (offparam >= curloblen) {
+				php_error_docref(NULL TSRMLS_CC, E_WARNING, "Offset is bigger than current LOB-Size - appending");
 				offset = curloblen;
 			} else {
 				offset = offparam;
@@ -3852,7 +3852,6 @@ PHP_FUNCTION(oci_lob_save)
 			WRONG_PARAM_COUNT;
 		}
 
-		offset++;
 		convert_to_string_ex(arg);
 		loblen = Z_STRLEN_PP(arg);