From: Matt Davis Date: Sat, 14 Jul 2018 00:10:42 +0000 (+0000) Subject: [llvm-mca] Remove unused InstRef formal from pre and post execute callbacks. NFC. X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=24ec170d1187bda9cddcedeb3175412a6912cd0c;p=llvm [llvm-mca] Remove unused InstRef formal from pre and post execute callbacks. NFC. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@337077 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/tools/llvm-mca/FetchStage.cpp b/tools/llvm-mca/FetchStage.cpp index 654f1778f85..3da117c0abc 100644 --- a/tools/llvm-mca/FetchStage.cpp +++ b/tools/llvm-mca/FetchStage.cpp @@ -29,7 +29,7 @@ bool FetchStage::execute(InstRef &IR) { return true; } -void FetchStage::postExecute(const InstRef &IR) { SM.updateNext(); } +void FetchStage::postExecute() { SM.updateNext(); } void FetchStage::cycleEnd() { // Find the first instruction which hasn't been retired. diff --git a/tools/llvm-mca/FetchStage.h b/tools/llvm-mca/FetchStage.h index c824b3221e5..620075d24fe 100644 --- a/tools/llvm-mca/FetchStage.h +++ b/tools/llvm-mca/FetchStage.h @@ -36,7 +36,7 @@ public: bool hasWorkToComplete() const override final; bool execute(InstRef &IR) override final; - void postExecute(const InstRef &IR) override final; + void postExecute() override final; void cycleEnd() override final; }; diff --git a/tools/llvm-mca/Pipeline.cpp b/tools/llvm-mca/Pipeline.cpp index eb95b0c496f..7c937e7b48b 100644 --- a/tools/llvm-mca/Pipeline.cpp +++ b/tools/llvm-mca/Pipeline.cpp @@ -47,14 +47,14 @@ bool Pipeline::executeStages(InstRef &IR) { return true; } -void Pipeline::preExecuteStages(const InstRef &IR) { +void Pipeline::preExecuteStages() { for (const std::unique_ptr &S : Stages) - S->preExecute(IR); + S->preExecute(); } -void Pipeline::postExecuteStages(const InstRef &IR) { +void Pipeline::postExecuteStages() { for (const std::unique_ptr &S : Stages) - S->postExecute(IR); + S->postExecute(); } void Pipeline::run() { @@ -75,10 +75,10 @@ void Pipeline::runCycle() { // Continue executing this cycle until any stage claims it cannot make // progress. while (true) { - preExecuteStages(IR); + preExecuteStages(); if (!executeStages(IR)) break; - postExecuteStages(IR); + postExecuteStages(); } for (auto &S : Stages) diff --git a/tools/llvm-mca/Pipeline.h b/tools/llvm-mca/Pipeline.h index 6bafc242b10..6916e422be3 100644 --- a/tools/llvm-mca/Pipeline.h +++ b/tools/llvm-mca/Pipeline.h @@ -59,9 +59,9 @@ class Pipeline { std::set Listeners; unsigned Cycles; - void preExecuteStages(const InstRef &IR); + void preExecuteStages(); bool executeStages(InstRef &IR); - void postExecuteStages(const InstRef &IR); + void postExecuteStages(); void runCycle(); bool hasWorkToProcess(); diff --git a/tools/llvm-mca/Stage.h b/tools/llvm-mca/Stage.h index 28216627634..9dbdcd89a33 100644 --- a/tools/llvm-mca/Stage.h +++ b/tools/llvm-mca/Stage.h @@ -50,12 +50,12 @@ public: /// Called prior to executing the list of stages. /// This can be called multiple times per cycle. - virtual void preExecute(const InstRef &IR) {} + virtual void preExecute() {} /// Called as a cleanup and finalization phase after each execution. /// This will only be called if all stages return a success from their /// execute callback. This can be called multiple times per cycle. - virtual void postExecute(const InstRef &IR) {} + virtual void postExecute() {} /// The primary action that this stage performs. /// Returning false prevents successor stages from having their 'execute'