From: Bert Hubert <bert.hubert@netherlabs.nl>
Date: Fri, 7 Jan 2011 13:02:37 +0000 (+0000)
Subject: don't truncate just before sending answer, plus improve logging a bit
X-Git-Tag: auth-3.0~419
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=24612ec409db61fa8e3a1adf8d7f40fbec3a1b5d;p=pdns

don't truncate just before sending answer, plus improve logging a bit


git-svn-id: svn://svn.powerdns.com/pdns/trunk/pdns@1828 d19b8d6e-7fed-0310-83ef-9ca221ded41b
---

diff --git a/pdns/nameserver.cc b/pdns/nameserver.cc
index 7aed04b4f..d6c3203f1 100644
--- a/pdns/nameserver.cc
+++ b/pdns/nameserver.cc
@@ -181,15 +181,9 @@ void UDPNameserver::send(DNSPacket *p)
   const char *buffer=p->getData();
   DLOG(L<<Logger::Notice<<"Sending a packet to "<< p->remote.toString() <<" ("<<p->len<<" octets)"<<endl);
   if(p->len > p->getMaxReplyLen()) {
-    shared_ptr<DNSPacket> sharedp(new DNSPacket(*p));
-    sharedp->truncate(p->getMaxReplyLen());
-    buffer=sharedp->getData();
-    if(sendto(sharedp->getSocket(),buffer,sharedp->len,0,(struct sockaddr *)(&sharedp->remote), sharedp->remote.getSocklen())<0) 
-      L<<Logger::Error<<"Error sending reply with sendto (socket="<<sharedp->getSocket()<<"): "<<strerror(errno)<<endl;
-  }
-  else {
-    if(sendto(p->getSocket(),buffer,p->len,0,(struct sockaddr *)(&p->remote),p->remote.getSocklen())<0)
-      L<<Logger::Error<<"Error sending reply with sendto (socket="<<p->getSocket()<<"): "<<strerror(errno)<<endl;
+    cerr<<"Weird, trying to send a message that needs truncation, "<<p->len<<" > "<<p->getMaxReplyLen()<<endl;
   }
+  if(sendto(p->getSocket(),buffer,p->len,0,(struct sockaddr *)(&p->remote),p->remote.getSocklen())<0)
+    L<<Logger::Error<<"Error sending reply with sendto (socket="<<p->getSocket()<<"): "<<strerror(errno)<<endl;
 }
 
diff --git a/pdns/packethandler.cc b/pdns/packethandler.cc
index 3570ffe0b..c38d3ee19 100644
--- a/pdns/packethandler.cc
+++ b/pdns/packethandler.cc
@@ -1148,7 +1148,8 @@ DNSPacket *PacketHandler::questionOrRecurse(DNSPacket *p, bool *shouldRecurse)
 
   DNSPacket *r=0;
   try {    
-    L << Logger::Notice<<"Remote "<< p->remote.toString() <<" wants a type " << p->qtype.getName() << " ("<<p->qtype.getCode()<<") about '"<<p->qdomain << "'" << endl;
+    L << Logger::Notice<<"Remote "<< p->remote.toString() <<" wants " << p->qtype.getName() << " for '"<<p->qdomain << 
+      "', do = " <<p->d_dnssecOk <<", bufsize = "<< p->getMaxReplyLen()<< endl;
 
     if(p->d.qr) { // QR bit from dns packet (thanks RA from N)
       L<<Logger::Error<<"Received an answer (non-query) packet from "<<p->getRemote()<<", dropping"<<endl;