From: Bert Hubert <bert.hubert@netherlabs.nl>
Date: Sun, 9 Jan 2011 21:05:03 +0000 (+0000)
Subject: fix giant memory leak, silence debugging, improve error message about unauth data... 
X-Git-Tag: auth-3.0~397
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=243140cfbb8dcdf3bbdf272b77f68cb2e23c2fc6;p=pdns

fix giant memory leak, silence debugging, improve error message about unauth data with hint how to resolve (thanks Stefan Arentz)


git-svn-id: svn://svn.powerdns.com/pdns/trunk/pdns@1850 d19b8d6e-7fed-0310-83ef-9ca221ded41b
---

diff --git a/pdns/dnsseckeeper.hh b/pdns/dnsseckeeper.hh
index 8d2850868..2f87ffc62 100644
--- a/pdns/dnsseckeeper.hh
+++ b/pdns/dnsseckeeper.hh
@@ -48,6 +48,7 @@ public:
     d_context.hash_id = orig.d_context.hash_id;
     d_context.f_rng = orig.d_context.f_rng;
     d_context.p_rng = orig.d_context.p_rng;
+    
     PDNSSEC_MC(N); 
     PDNSSEC_MC(E); PDNSSEC_MC(D); PDNSSEC_MC(P); PDNSSEC_MC(Q); PDNSSEC_MC(DP); PDNSSEC_MC(DQ); PDNSSEC_MC(QP); PDNSSEC_MC(RN); PDNSSEC_MC(RP); PDNSSEC_MC(RQ);
   }
@@ -61,7 +62,10 @@ public:
     d_context.hash_id = orig.d_context.hash_id;
     d_context.f_rng = orig.d_context.f_rng;
     d_context.p_rng = orig.d_context.p_rng;
-
+    
+    PDNSSEC_MF(N); 
+    PDNSSEC_MF(E); PDNSSEC_MF(D); PDNSSEC_MF(P); PDNSSEC_MF(Q); PDNSSEC_MF(DP); PDNSSEC_MF(DQ); PDNSSEC_MF(QP); PDNSSEC_MF(RN); PDNSSEC_MF(RP); PDNSSEC_MF(RQ);
+    
     PDNSSEC_MC(N); 
     PDNSSEC_MC(E); PDNSSEC_MC(D); PDNSSEC_MC(P); PDNSSEC_MC(Q); PDNSSEC_MC(DP); PDNSSEC_MC(DQ); PDNSSEC_MC(QP); PDNSSEC_MC(RN); PDNSSEC_MC(RP); PDNSSEC_MC(RQ);
     return *this;
diff --git a/pdns/dnssecsigner.cc b/pdns/dnssecsigner.cc
index c8a34fefd..719f9f561 100644
--- a/pdns/dnssecsigner.cc
+++ b/pdns/dnssecsigner.cc
@@ -141,7 +141,7 @@ void fillOutRRSIG(DNSSECPrivateKey& dpk, const std::string& signQName, RRSIGReco
       return;
     }
     else
-      cerr<<"Miss!"<<endl;
+      ; // cerr<<"Miss!"<<endl;
   }
   
   int ret=rsa_pkcs1_sign(&rc.getContext(), RSA_PRIVATE, 
diff --git a/pdns/packethandler.cc b/pdns/packethandler.cc
index 915a67def..9b6a8cef8 100644
--- a/pdns/packethandler.cc
+++ b/pdns/packethandler.cc
@@ -1320,7 +1320,7 @@ DNSPacket *PacketHandler::questionOrRecurse(DNSPacket *p, bool *shouldRecurse)
       cerr<<"Have unauth data, so need to hunt for best NS records"<<endl;
       if(tryReferral(p, r, sd, target))
         goto sendit;
-      cerr<<"Should not get here!!"<<endl;
+      cerr<<"Should not get here: please run pdnssec rectify-zone "<<sd.qname<<endl;
     }
     else {
       cerr<<"Have some data, but not the right data"<<endl;