From: Bruce Momjian <bruce@momjian.us>
Date: Tue, 3 Apr 2018 18:01:14 +0000 (-0400)
Subject: C comment:  mention null handling in BuildTupleFromCStrings()
X-Git-Tag: REL_11_BETA1~382
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=242408dbef283ff148a3a671a7f4ebbad6118b22;p=postgresql

C comment:  mention null handling in BuildTupleFromCStrings()

Discussion: https://postgr.es/m/CAFjFpRcF-wNbe0w-m3NpkEwr9shmOZ=GoESOzd2Wog9h55J8sA@mail.gmail.com

Author: Ashutosh Bapat
---

diff --git a/src/backend/executor/execTuples.c b/src/backend/executor/execTuples.c
index ea06aeedb2..d14bf2ad69 100644
--- a/src/backend/executor/execTuples.c
+++ b/src/backend/executor/execTuples.c
@@ -1204,7 +1204,10 @@ BuildTupleFromCStrings(AttInMetadata *attinmeta, char **values)
 	dvalues = (Datum *) palloc(natts * sizeof(Datum));
 	nulls = (bool *) palloc(natts * sizeof(bool));
 
-	/* Call the "in" function for each non-dropped attribute */
+	/*
+	 * Call the "in" function for each non-dropped attribute, even for nulls,
+	 * to support domains.
+	 */
 	for (i = 0; i < natts; i++)
 	{
 		if (!TupleDescAttr(tupdesc, i)->attisdropped)