From: Heikki Linnakangas <heikki.linnakangas@iki.fi>
Date: Tue, 9 Feb 2010 20:31:35 +0000 (+0000)
Subject: Fix bug in GIN WAL redo cleanup function: don't free fake relcache entry
X-Git-Tag: REL8_4_3~46
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=23eec895df920619ae4e0453c2f238b74191bc73;p=postgresql

Fix bug in GIN WAL redo cleanup function: don't free fake relcache entry
while it's still being used.

Backpatch to 8.4, where the fake relcache method was introduced.
---

diff --git a/src/backend/access/gin/ginxlog.c b/src/backend/access/gin/ginxlog.c
index 1f008b727f..74601ff548 100644
--- a/src/backend/access/gin/ginxlog.c
+++ b/src/backend/access/gin/ginxlog.c
@@ -8,7 +8,7 @@
  * Portions Copyright (c) 1994, Regents of the University of California
  *
  * IDENTIFICATION
- *			 $PostgreSQL: pgsql/src/backend/access/gin/ginxlog.c,v 1.19 2009/06/11 14:48:53 momjian Exp $
+ *			 $PostgreSQL: pgsql/src/backend/access/gin/ginxlog.c,v 1.19.2.1 2010/02/09 20:31:35 heikki Exp $
  *-------------------------------------------------------------------------
  */
 #include "postgres.h"
@@ -773,8 +773,6 @@ ginContinueSplit(ginIncompleteSplit *split)
 									   GinPageGetOpaque(page)->maxoff))->key;
 	}
 
-	FreeFakeRelcacheEntry(reln);
-
 	btree.rightblkno = split->rightBlkno;
 
 	stack.blkno = split->leftBlkno;
@@ -785,6 +783,8 @@ ginContinueSplit(ginIncompleteSplit *split)
 	findParents(&btree, &stack, split->rootBlkno);
 	ginInsertValue(&btree, stack.parent);
 
+	FreeFakeRelcacheEntry(reln);
+
 	UnlockReleaseBuffer(buffer);
 }