From: Ted Kremenek <kremenek@apple.com>
Date: Fri, 21 Mar 2014 17:34:28 +0000 (+0000)
Subject: Placate -Wunreachable-code by removing unnecessary logic to handle NUM_OPENMP_DEFAULT... 
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=23df8218939d88dcd15e8f51a1d97d5829016694;p=clang

Placate -Wunreachable-code by removing unnecessary logic to handle NUM_OPENMP_DEFAULT_KINDS <= 1.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@204487 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Sema/SemaOpenMP.cpp b/lib/Sema/SemaOpenMP.cpp
index e43b4f453e..dc2a68d418 100644
--- a/lib/Sema/SemaOpenMP.cpp
+++ b/lib/Sema/SemaOpenMP.cpp
@@ -937,7 +937,9 @@ OMPClause *Sema::ActOnOpenMPDefaultClause(OpenMPDefaultClauseKind Kind,
                                           SourceLocation EndLoc) {
   if (Kind == OMPC_DEFAULT_unknown) {
     std::string Values;
-    std::string Sep(NUM_OPENMP_DEFAULT_KINDS > 1 ? ", " : "");
+    static_assert(NUM_OPENMP_DEFAULT_KINDS > 1,
+                  "NUM_OPENMP_DEFAULT_KINDS not greater than 1");
+    std::string Sep(", ");
     for (unsigned i = OMPC_DEFAULT_unknown + 1;
          i < NUM_OPENMP_DEFAULT_KINDS; ++i) {
       Values += "'";