From: Takayuki Nagata Date: Thu, 4 Aug 2016 09:06:06 +0000 (+0900) Subject: libprocps: use float to calculate %use of slabtop X-Git-Tag: v3.3.13rc1~103^2^2 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=23ba442c886f6250d1068a82fb7d0fc544acfd63;p=procps-ng libprocps: use float to calculate %use of slabtop In some environments, 100 * nr_active_objs is calculated at first, and the result of lower 32bits is divided by nr_objs. This occurs even in a 64-bit architecture. So nr_active_objes > 42949672, %use will be incorrect. This fix casts type of nr_active_objs to float to calculate correctly the %use in 32-bit/64-bit architectures. Signed-off-by: Takayuki Nagata --- diff --git a/proc/slab.c b/proc/slab.c index 444b79cc..49177416 100644 --- a/proc/slab.c +++ b/proc/slab.c @@ -179,7 +179,7 @@ static int parse_slabinfo20(struct slab_info **list, struct slab_stat *stats, curr->cache_size = (unsigned long)curr->nr_slabs * curr->pages_per_slab * page_size; if (curr->nr_objs) { - curr->use = 100 * curr->nr_active_objs / curr->nr_objs; + curr->use = 100 * (float)curr->nr_active_objs / curr->nr_objs; stats->nr_active_caches++; } else curr->use = 0; @@ -258,7 +258,7 @@ static int parse_slabinfo11(struct slab_info **list, struct slab_stat *stats, curr->cache_size = (unsigned long)curr->nr_slabs * curr->pages_per_slab * page_size; if (curr->nr_objs) { - curr->use = 100 * curr->nr_active_objs / curr->nr_objs; + curr->use = 100 * (float)curr->nr_active_objs / curr->nr_objs; stats->nr_active_caches++; } else curr->use = 0;