From: Todd C. Miller <Todd.Miller@courtesan.com>
Date: Wed, 27 Jan 2016 23:07:35 +0000 (-0700)
Subject: Avoid possible NULL deref found by clang analyzer.
X-Git-Tag: SUDO_1_8_16^2~35
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=23a82ab2e8865ae01260bad7d6079e8d6416ec1d;p=sudo

Avoid possible NULL deref found by clang analyzer.
---

diff --git a/plugins/sudoers/sssd.c b/plugins/sudoers/sssd.c
index 2bbfd4934..316ee38a5 100644
--- a/plugins/sudoers/sssd.c
+++ b/plugins/sudoers/sssd.c
@@ -1238,8 +1238,7 @@ sudo_sss_display_cmnd(struct sudo_nss *nss, struct passwd *pw)
     debug_decl(sudo_sss_display_cmnd, SUDOERS_DEBUG_SSSD);
 
     if (handle == NULL)
-	goto done;
-
+	debug_return_int(-1);
     if (sudo_sss_checkpw(nss, pw) != 0)
 	debug_return_int(-1);