From: Todd C. Miller <Todd.Miller@courtesan.com>
Date: Mon, 26 Mar 2012 15:03:23 +0000 (-0400)
Subject: Quiet a clang-analyzer dead store warning.
X-Git-Tag: SUDO_1_8_5~1^2~119
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=238186abc9a28fa865cbee52a4961121775c9d4c;p=sudo

Quiet a clang-analyzer dead store warning.
---

diff --git a/plugins/sudoers/visudo.c b/plugins/sudoers/visudo.c
index 5aadabb09..923e1235f 100644
--- a/plugins/sudoers/visudo.c
+++ b/plugins/sudoers/visudo.c
@@ -207,9 +207,8 @@ main(int argc, char *argv[])
 		usage(1);
 	}
     }
-    argc -= optind;
-    argv += optind;
-    if (argc)
+    /* There should be no other command line arguments. */
+    if (argc - optind != 0)
 	usage(1);
 
     sudo_setpwent();