From: Ilia Alshanetsky <iliaa@php.net>
Date: Fri, 29 Jul 2005 15:43:37 +0000 (+0000)
Subject: Fixed bug #33904 (input array keys being escaped when magic quotes is off).
X-Git-Tag: RELEASE_2_0_0~75
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=22db4041320761e5ae76e3581797d7e0db009285;p=php

Fixed bug #33904 (input array keys being escaped when magic quotes is off).
---

diff --git a/NEWS b/NEWS
index 8d10f9218e..623faa96e5 100644
--- a/NEWS
+++ b/NEWS
@@ -2,6 +2,8 @@ PHP                                                                        NEWS
 |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
 ?? ??? 2005, PHP 5.1
 - Fixed bug #33917 (number_format() output with > 1 char separators). (Jani)
+- Fixed bug #33904 (input array keys being escaped when magic quotes is off). 
+  (Ilia)
 - Fixed bug #33899 (CLI: setting extension_dir=some/path extension=foobar.so
   does not work). (Jani)
 - Fixed bug #33882 (CLI was looking for php.ini in wrong path). (Hartmut)
diff --git a/main/php_variables.c b/main/php_variables.c
index 79caaec646..31f80674e1 100644
--- a/main/php_variables.c
+++ b/main/php_variables.c
@@ -183,7 +183,13 @@ plain_var:
 				zend_hash_next_index_insert(symtable1, &gpc_element, sizeof(zval *), (void **) &gpc_element_p);
 			} else {
 				zval **tmp;
-				char *escaped_index = php_addslashes(index, index_len, &index_len, 0 TSRMLS_CC);
+				char *escaped_index;
+
+				if (PG(magic_quotes_gpc)) { 
+					escaped_index = php_addslashes(index, index_len, &index_len, 0 TSRMLS_CC);
+				} else {
+					escaped_index = index;
+				}
 				/* 
 				 * According to rfc2965, more specific paths are listed above the less specific ones.
 				 * If we encounter a duplicate cookie name, we should skip it, since it is not possible
@@ -196,7 +202,9 @@ plain_var:
 					break;
 				}
 				zend_symtable_update(symtable1, escaped_index, index_len + 1, &gpc_element, sizeof(zval *), (void **) &gpc_element_p);
-				efree(escaped_index);
+				if (PG(magic_quotes_gpc)) { 
+					efree(escaped_index);
+				}
 			}
 			break;
 		}