From: Victor Stinner <victor.stinner@gmail.com>
Date: Wed, 3 May 2017 00:12:34 +0000 (+0200)
Subject: regrtest: always show before/after of modified env (#1407)
X-Git-Tag: v3.5.4rc1~175
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=22982350235f8c5821b71661a5616423e1c7fcc0;p=python

regrtest: always show before/after of modified env (#1407)

Buildbots don't run tests with -vv and so only log "xxx was modified
by test_xxx" which is not enough to debug such random issue. In many
cases, I'm unable to reproduce the warning and so unable to fix it.

Always logging the value before and value after should help to debug
such warning on buildbots.
(cherry picked from commit ec4b17239d899550be4ee6104b61751bb3c70382)
---

diff --git a/Lib/test/regrtest.py b/Lib/test/regrtest.py
index 12909ec477..d7ca07b664 100755
--- a/Lib/test/regrtest.py
+++ b/Lib/test/regrtest.py
@@ -1267,10 +1267,9 @@ class saved_test_environment:
                     print("Warning -- {} was modified by {}".format(
                                                  name, self.testname),
                                                  file=sys.stderr)
-                    if self.verbose > 1 and not self.pgo:
-                        print("  Before: {}\n  After:  {} ".format(
-                                                  original, current),
-                                                  file=sys.stderr)
+                    print("  Before: {}\n  After:  {} ".format(
+                                              original, current),
+                                              file=sys.stderr)
         return False