From: Matthew Fernandez <matthew.fernandez@gmail.com>
Date: Sat, 5 Nov 2022 02:37:23 +0000 (-0700)
Subject: smyrna: remove unreachable code in 'create_column'
X-Git-Tag: 7.0.2~18^2~5
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=213ac201795491fcd509746024c466b6427ac81c;p=graphviz

smyrna: remove unreachable code in 'create_column'

This function is only ever called into with non-null pointers.
---

diff --git a/cmd/smyrna/tvnodes.c b/cmd/smyrna/tvnodes.c
index 75b77ffb4..92d6ae1ba 100644
--- a/cmd/smyrna/tvnodes.c
+++ b/cmd/smyrna/tvnodes.c
@@ -8,6 +8,7 @@
  * Contributors: Details at https://graphviz.org
  *************************************************************************/
 
+#include <assert.h>
 #include "tvnodes.h"
 #include "viewport.h"
 #include "topviewfuncs.h"
@@ -254,8 +255,7 @@ static GtkTreeStore *update_tree_store(GtkTreeStore * store, int ncolumns,
 
 static void create_column(gridCol * c, GtkTreeView * tree, int id)
 {
-    if (!c)
-	return;
+    assert(c != NULL);
     switch (c->type) {
     case G_TYPE_STRING:
     case G_TYPE_INT: