From: Georg Brandl <georg@python.org>
Date: Tue, 31 Mar 2009 15:52:41 +0000 (+0000)
Subject: #5548: do return the new module from PyMODINIT_FUNC functions.
X-Git-Tag: v3.1a2~134
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=21151760d9651767227c0676cb51915e53610f9e;p=python

#5548: do return the new module from PyMODINIT_FUNC functions.
---

diff --git a/Doc/extending/extending.rst b/Doc/extending/extending.rst
index b035d94f9d..d7f1357c5e 100644
--- a/Doc/extending/extending.rst
+++ b/Doc/extending/extending.rst
@@ -1266,12 +1266,13 @@ All that a client module must do in order to have access to the function
    {
        PyObject *m;
 
-       m = Py_InitModule("client", ClientMethods);
+       m = PyModule_Create(&clientmodule);
        if (m == NULL)
-           return;
+           return NULL;
        if (import_spam() < 0)
-           return;
+           return NULL;
        /* additional initialization can happen here */
+       return m;
    }
 
 The main disadvantage of this approach is that the file :file:`spammodule.h` is
diff --git a/Doc/extending/newtypes.rst b/Doc/extending/newtypes.rst
index c20e96f589..83c95f2f4b 100644
--- a/Doc/extending/newtypes.rst
+++ b/Doc/extending/newtypes.rst
@@ -871,6 +871,7 @@ the module's :cfunc:`init` function. ::
 
        Py_INCREF(&ShoddyType);
        PyModule_AddObject(m, "Shoddy", (PyObject *) &ShoddyType);
+       return m;
    }
 
 Before calling :cfunc:`PyType_Ready`, the type structure must have the