From: Ulf Wendel Date: Mon, 19 Oct 2009 20:07:25 +0000 (+0000) Subject: Using require[_once] instead of include. Adding logic to connect.inc to detect multip... X-Git-Tag: php-5.4.0alpha1~191^2~2493 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=210353caee6118c3d9872309dad705aa505bd4a4;p=php Using require[_once] instead of include. Adding logic to connect.inc to detect multiple inclusions of connect.inc which leads to a Fatal error because of my_mysqli_connect() function redefinition. Some tests did include connect.inc twice -> run-tests - even the one from trunk - did not detect Fatal error in SKIPIF -> false-positive test result... --- diff --git a/ext/mysqli/tests/001.phpt b/ext/mysqli/tests/001.phpt index 4e19d81090..ed09b2eecb 100644 --- a/ext/mysqli/tests/001.phpt +++ b/ext/mysqli/tests/001.phpt @@ -8,7 +8,7 @@ require_once('skipifconnectfailure.inc'); ?> --FILE-- --FILE-- --CLEAN-- --FILE-- --CLEAN-- --CLEAN-- --FILE-- --CLEAN-- --FILE-- --CLEAN-- --FILE-- --CLEAN-- --FILE-- --CLEAN-- --FILE-- --CLEAN-- --FILE-- --CLEAN-- --FILE-- --CLEAN-- --FILE-- --CLEAN-- --FILE-- --CLEAN-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --CLEAN-- --FILE-- --CLEAN-- --FILE-- --CLEAN-- --FILE-- --CLEAN-- --FILE-- --CLEAN-- --FILE-- --CLEAN-- --FILE-- --CLEAN-- --FILE-- --CLEAN-- --FILE-- --FILE-- --FILE-- --CLEAN-- --FILE-- --FILE-- --FILE-- --CLEAN-- --FILE-- --FILE-- --FILE-- --FILE-- --CLEAN-- --CLEAN-- --FILE-- --CLEAN-- --FILE-- --FILE-- --CLEAN-- --CLEAN-- --FILE-- --CLEAN-- --FILE-- --CLEAN-- --FILE-- --FILE-- --FILE-- --CLEAN-- --FILE-- --CLEAN-- --FILE-- --CLEAN-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --CLEAN-- --FILE-- --CLEAN-- --FILE-- --CLEAN-- --FILE-- --CLEAN-- --FILE-- --CLEAN-- --FILE-- --FILE-- --FILE-- ') == 1) { ?> --FILE-- --FILE-- --CLEAN-- --CLEAN-- --FILE-- multi_query('SELECT 1;SELECT 2'); diff --git a/ext/mysqli/tests/070.phpt b/ext/mysqli/tests/070.phpt index eee5125133..b71d9b2e49 100644 --- a/ext/mysqli/tests/070.phpt +++ b/ext/mysqli/tests/070.phpt @@ -7,7 +7,7 @@ require_once('skipifconnectfailure.inc'); ?> --FILE-- ping()); diff --git a/ext/mysqli/tests/071.phpt b/ext/mysqli/tests/071.phpt index 8888fb1706..4788a60913 100644 --- a/ext/mysqli/tests/071.phpt +++ b/ext/mysqli/tests/071.phpt @@ -8,7 +8,7 @@ require_once('skipifconnectfailure.inc'); ?> --FILE-- --FILE-- --FILE-- embedded); var_dump($driver->client_version); diff --git a/ext/mysqli/tests/074.phpt b/ext/mysqli/tests/074.phpt index 883655bc5e..7d9d01b3be 100644 --- a/ext/mysqli/tests/074.phpt +++ b/ext/mysqli/tests/074.phpt @@ -8,7 +8,7 @@ require_once('skipifconnectfailure.inc'); --FILE-- --FILE-- --FILE-- --FILE-- multi_query('SELECT 1;SELECT 2'); diff --git a/ext/mysqli/tests/bug32405.phpt b/ext/mysqli/tests/bug32405.phpt index 24bcdb4d0f..0b3cad50ff 100644 --- a/ext/mysqli/tests/bug32405.phpt +++ b/ext/mysqli/tests/bug32405.phpt @@ -7,7 +7,7 @@ require_once('skipifconnectfailure.inc'); ?> --FILE-- --CLEAN-- --FILE-- --CLEAN-- query("DROP TABLE IF EXISTS test_bint"); @@ -53,7 +53,7 @@ EOSQL; ?> --CLEAN-- --FILE-- --CLEAN-- --CLEAN-- query('select 1'); diff --git a/ext/mysqli/tests/bug36745.phpt b/ext/mysqli/tests/bug36745.phpt index 511eaf38fd..5e203e14eb 100644 --- a/ext/mysqli/tests/bug36745.phpt +++ b/ext/mysqli/tests/bug36745.phpt @@ -7,7 +7,7 @@ require_once('skipifconnectfailure.inc'); ?> --FILE-- --CLEAN-- --FILE-- --CLEAN-- ') == 1)) { ?> --FILE-- --FILE-- stmt_init(); diff --git a/ext/mysqli/tests/bug39457.phpt b/ext/mysqli/tests/bug39457.phpt index b834ff1b70..ec9239bb15 100644 --- a/ext/mysqli/tests/bug39457.phpt +++ b/ext/mysqli/tests/bug39457.phpt @@ -1,13 +1,13 @@ --TEST-- Bug #39457 (Multiple invoked OO connections never close) --SKIPIF-- - --FILE-- connect($host, $user, $passwd, $db, $port, $socket); diff --git a/ext/mysqli/tests/bug42548.phpt b/ext/mysqli/tests/bug42548.phpt index c9950be3a1..ef0c831e4d 100644 --- a/ext/mysqli/tests/bug42548.phpt +++ b/ext/mysqli/tests/bug42548.phpt @@ -52,7 +52,7 @@ print "done!"; ?> --CLEAN-- --FILE-- query('DROP PROCEDURE IF EXISTS p')) @@ -74,7 +73,7 @@ if (mysqli_get_server_version($link) <= 50000) { ?> --CLEAN-- --FILE-- init(); $mysqli->init(); - echo "done"; + echo "done"; ?> --EXPECTF-- done diff --git a/ext/mysqli/tests/bug48909.phpt b/ext/mysqli/tests/bug48909.phpt index 55c85a6860..81df544190 100644 --- a/ext/mysqli/tests/bug48909.phpt +++ b/ext/mysqli/tests/bug48909.phpt @@ -7,7 +7,7 @@ require_once('skipifconnectfailure.inc'); ?> --FILE-- real_connect($host, $user, $passwd, $db, $port, $socket, $flags); - } else { - parent::__construct($host, $user, $passwd, $db, $port, $socket); + $flags = ($enable_env_flags) ? $connect_flags : false; + + if ($flags !== false) { + parent::init(); + $this->real_connect($host, $user, $passwd, $db, $port, $socket, $flags); + } else { + parent::__construct($host, $user, $passwd, $db, $port, $socket); + } } } + } else { + printf("skip Eeeek/BUG/FIXME - connect.inc included twice! skipif bug?\n"); } ?> \ No newline at end of file diff --git a/ext/mysqli/tests/mysqli_affected_rows.phpt b/ext/mysqli/tests/mysqli_affected_rows.phpt index 6cb5451c0b..958b83cb3c 100644 --- a/ext/mysqli/tests/mysqli_affected_rows.phpt +++ b/ext/mysqli/tests/mysqli_affected_rows.phpt @@ -8,7 +8,7 @@ mysqli_affected_rows() ?> --FILE-- affected_rows ?> --FILE-- affected_rows)) diff --git a/ext/mysqli/tests/mysqli_autocommit.phpt b/ext/mysqli/tests/mysqli_autocommit.phpt index cdd5559767..f1f63e7f33 100644 --- a/ext/mysqli/tests/mysqli_autocommit.phpt +++ b/ext/mysqli/tests/mysqli_autocommit.phpt @@ -26,7 +26,7 @@ mysqli_autocommit() ?> --FILE-- autocommit() ?> --FILE-- --FILE-- ') == 1) { ?> --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- error --SKIPIF-- - --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --CLEAN-- --FILE-- --FILE-- --EXPECTF-- -done! \ No newline at end of file +done! diff --git a/ext/mysqli/tests/mysqli_get_charset.phpt b/ext/mysqli/tests/mysqli_get_charset.phpt index 314853dc02..8f81b3342e 100644 --- a/ext/mysqli/tests/mysqli_get_charset.phpt +++ b/ext/mysqli/tests/mysqli_get_charset.phpt @@ -10,7 +10,7 @@ if (!function_exists('mysqli_get_charset')) ?> --FILE-- --FILE-- --CLEAN-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --CLEAN-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --CLEAN-- real_connect($host, $user, $passwd, $db, $port, $socket))) printf("[009] Expecting boolean/true got %s/%s\n", gettype($tmp), $tmp); diff --git a/ext/mysqli/tests/mysqli_pconnect.phpt b/ext/mysqli/tests/mysqli_pconnect.phpt index 57b44ebaf2..fbb1092e6e 100644 --- a/ext/mysqli/tests/mysqli_pconnect.phpt +++ b/ext/mysqli/tests/mysqli_pconnect.phpt @@ -11,7 +11,7 @@ if (!stristr(mysqli_get_client_info(), 'mysqlnd')) ?> --FILE-- --FILE-- --CLEAN-- --FILE-- --CLEAN-- --FILE-- --FILE-- --CLEAN-- --CLEAN-- --FILE-- --FILE-- --FILE-- --CLEAN-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- ') == 1) ? "unicode":"string"; diff --git a/ext/mysqli/tests/mysqli_stmt_bind_result_bit.phpt b/ext/mysqli/tests/mysqli_stmt_bind_result_bit.phpt index 1eef767478..acf0d0be2d 100644 --- a/ext/mysqli/tests/mysqli_stmt_bind_result_bit.phpt +++ b/ext/mysqli/tests/mysqli_stmt_bind_result_bit.phpt @@ -8,7 +8,7 @@ require_once('skipifconnectfailure.inc'); ?> --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --CLEAN-- --FILE-- --FILE-- --FILE-- --CLEAN-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE-- --FILE--