From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Thu, 13 Oct 2005 15:34:19 +0000 (+0000)
Subject: Fix small oversight in recent patch to add more CREATE-FUNCTION-time
X-Git-Tag: REL8_1_0BETA4~75
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=203015ebddee0bc7ee8db97785c2abaa0a3e79e4;p=postgresql

Fix small oversight in recent patch to add more CREATE-FUNCTION-time
syntax checking to plpgsql: check_sql_expr() wasn't being called by
make_select_stmt(), so that there was no SQL syntax check for SELECT
statements.
---

diff --git a/src/pl/plpgsql/src/gram.y b/src/pl/plpgsql/src/gram.y
index 494b13001f..8e7097c961 100644
--- a/src/pl/plpgsql/src/gram.y
+++ b/src/pl/plpgsql/src/gram.y
@@ -4,7 +4,7 @@
  *						  procedural language
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/pl/plpgsql/src/gram.y,v 1.81 2005/09/14 13:46:47 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/pl/plpgsql/src/gram.y,v 1.82 2005/10/13 15:34:19 tgl Exp $
  *
  *	  This software is copyrighted by Jan Wieck - Hamburg.
  *
@@ -1986,6 +1986,8 @@ make_select_stmt(void)
 		expr->params[nparams] = params[nparams];
 	plpgsql_dstring_free(&ds);
 
+	check_sql_expr(expr->query);
+
 	if (have_into)
 	{
 		PLpgSQL_stmt_select *select;