From: Peter Eisentraut Date: Fri, 7 Sep 2018 13:01:25 +0000 (+0200) Subject: libpq: Change "options" dispchar to normal X-Git-Tag: REL_12_BETA1~1602 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=1fea1e325492b10f645809204631426bb6abbe6e;p=postgresql libpq: Change "options" dispchar to normal libpq connection options as returned by PQconndefaults() have a "dispchar" field that determines (among other things) whether an option is a "debug" option, which shouldn't be shown by default to clients. postgres_fdw makes use of that to control which connection options to accept from a foreign server configuration. Curiously, the "options" option, which allows passing configuration settings to the backend server, was listed as a debug option, which prevented it from being used by postgres_fdw. Maybe it was once meant for debugging, but it's clearly in general use nowadays. So change the dispchar for it to be the normal non-debug case. Also remove the "debug" reference from its label field. Reported-by: Shinoda, Noriyoshi --- diff --git a/src/interfaces/libpq/fe-connect.c b/src/interfaces/libpq/fe-connect.c index a8048ffad2..db5aacd0e9 100644 --- a/src/interfaces/libpq/fe-connect.c +++ b/src/interfaces/libpq/fe-connect.c @@ -236,7 +236,7 @@ static const internalPQconninfoOption PQconninfoOptions[] = { offsetof(struct pg_conn, pgtty)}, {"options", "PGOPTIONS", DefaultOption, NULL, - "Backend-Debug-Options", "D", 40, + "Backend-Options", "", 40, offsetof(struct pg_conn, pgoptions)}, {"application_name", "PGAPPNAME", NULL, NULL,