From: bert hubert <bert.hubert@netherlabs.nl>
Date: Mon, 17 Jun 2019 20:26:29 +0000 (+0200)
Subject: clarify code with a comment
X-Git-Tag: dnsdist-1.4.0-rc1~102^2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=1fbf6feac8224a53413dd8107512ae14483ac0e8;p=pdns

clarify code with a comment
---

diff --git a/pdns/slavecommunicator.cc b/pdns/slavecommunicator.cc
index 6808cf888..53b66197c 100644
--- a/pdns/slavecommunicator.cc
+++ b/pdns/slavecommunicator.cc
@@ -92,6 +92,7 @@ void CommunicatorClass::ixfrSuck(const DNSName &domain, const TSIGTriplet& tt, c
     DNSSECKeeper dk (&B); // reuse our UeberBackend copy for DNSSECKeeper
 
     bool wrongDomainKind = false;
+    // this checks three error conditions, and sets wrongDomainKind if we hit the third & had an error
     if(!B.getDomainInfo(domain, di) || !di.backend || (wrongDomainKind = true, di.kind != DomainInfo::Slave)) { // di.backend and B are mostly identical
       if(wrongDomainKind)
         g_log<<Logger::Error<<"Can't determine backend for domain '"<<domain<<"', not configured as slave"<<endl;
@@ -312,6 +313,7 @@ void CommunicatorClass::suck(const DNSName &domain, const ComboAddress& remote)
   try {
     DNSSECKeeper dk (&B); // reuse our UeberBackend copy for DNSSECKeeper
     bool wrongDomainKind = false;
+    // this checks three error conditions & sets wrongDomainKind if we hit the third
     if(!B.getDomainInfo(domain, di) || !di.backend || (wrongDomainKind = true, di.kind != DomainInfo::Slave)) { // di.backend and B are mostly identical
       if(wrongDomainKind)
         g_log<<Logger::Error<<"Can't determine backend for domain '"<<domain<<"', not configured as slave"<<endl;