From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Thu, 11 Mar 2010 21:47:19 +0000 (+0000)
Subject: Add missing reset of need_initialization in reloptions code.
X-Git-Tag: REL9_0_ALPHA5~109
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=1f44a313bdffd887ddea1f51681420ce5621fb1d;p=postgresql

Add missing reset of need_initialization in reloptions code.

This resulted in useless extra work during every call of parseRelOptions,
but no bad effects other than that.  Noted by Alvaro.
---

diff --git a/src/backend/access/common/reloptions.c b/src/backend/access/common/reloptions.c
index 052982145d..2b099e806c 100644
--- a/src/backend/access/common/reloptions.c
+++ b/src/backend/access/common/reloptions.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/access/common/reloptions.c,v 1.33 2010/02/26 02:00:32 momjian Exp $
+ *	  $PostgreSQL: pgsql/src/backend/access/common/reloptions.c,v 1.34 2010/03/11 21:47:19 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -244,8 +244,9 @@ static void
 initialize_reloptions(void)
 {
 	int			i;
-	int			j = 0;
+	int			j;
 
+	j = 0;
 	for (i = 0; boolRelOpts[i].gen.name; i++)
 		j++;
 	for (i = 0; intRelOpts[i].gen.name; i++)
@@ -302,6 +303,9 @@ initialize_reloptions(void)
 
 	/* add a list terminator */
 	relOpts[j] = NULL;
+
+	/* flag the work is complete */
+	need_initialization = false;
 }
 
 /*