From: R. David Murray Date: Wed, 27 May 2009 20:56:59 +0000 (+0000) Subject: Merged revisions 72966 via svnmerge from X-Git-Tag: v3.1rc1~29 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=1f1b9d3d0de4dcf272f7908ce001833ac4cdabbb;p=python Merged revisions 72966 via svnmerge from svn+ssh://pythondev@svn.python.org/python/trunk ........ r72966 | r.david.murray | 2009-05-27 16:07:21 -0400 (Wed, 27 May 2009) | 4 lines fix issue #6121 by stripping spaces from the argument in the 'help' function. ........ --- diff --git a/Lib/pydoc.py b/Lib/pydoc.py index dd4fdfdba8..6475decc29 100755 --- a/Lib/pydoc.py +++ b/Lib/pydoc.py @@ -1740,6 +1740,7 @@ has the same effect as typing a particular string at the help> prompt. def help(self, request): if type(request) is type(''): + request = request.strip() if request == 'help': self.intro() elif request == 'keywords': self.listkeywords() elif request == 'symbols': self.listsymbols() diff --git a/Lib/test/test_pydoc.py b/Lib/test/test_pydoc.py index 95a11af977..03b353910c 100644 --- a/Lib/test/test_pydoc.py +++ b/Lib/test/test_pydoc.py @@ -254,6 +254,12 @@ class PyDocDocTest(unittest.TestCase): self.assertEqual(expected, result, "documentation for missing module found") + def test_input_strip(self): + missing_module = " test.i_am_not_here " + result = str(run_pydoc(missing_module), 'ascii') + expected = missing_pattern % missing_module.strip() + self.assertEqual(expected, result) + class TestDescriptions(unittest.TestCase): diff --git a/Misc/NEWS b/Misc/NEWS index 626b512ea9..d1117097d6 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -34,6 +34,9 @@ Core and Builtins Library ------- +- Issue #6121: pydoc now ignores leading and trailing spaces in the + argument to the 'help' function. + - Issue #6118: urllib.parse.quote_plus ignored the encoding and errors arguments for strings with a space in them.