From: Aki Tuomi <cmouse@cmouse.fi>
Date: Mon, 24 Jul 2017 06:34:09 +0000 (+0300)
Subject: geoipbackend: Allow mixing static and service lookup.
X-Git-Tag: dnsdist-1.2.0~11^2~2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=1ecce4462e2199cd313b0a299a81dfac839f4fba;p=pdns

geoipbackend: Allow mixing static and service lookup.

This allows using service records at apex level.

Closes #3747
---

diff --git a/modules/geoipbackend/geoipbackend.cc b/modules/geoipbackend/geoipbackend.cc
index b10a54b63..929f5345b 100644
--- a/modules/geoipbackend/geoipbackend.cc
+++ b/modules/geoipbackend/geoipbackend.cc
@@ -368,8 +368,7 @@ void GeoIPBackend::lookup(const QType &qtype, const DNSName& qdomain, DNSPacket
 
   gl.netmask = 0;
 
-  if (this->lookup_static(dom, search, qtype, qdomain, ip, gl, v6))
-    return;
+  (void)this->lookup_static(dom, search, qtype, qdomain, ip, gl, v6);
 
   auto target = dom.services.find(search);
   if (target == dom.services.end()) return; // no hit
@@ -389,6 +388,15 @@ void GeoIPBackend::lookup(const QType &qtype, const DNSName& qdomain, DNSPacket
       return;
   }
 
+  if (!d_result.empty()) {
+    L<<Logger::Error<<
+       "Cannot have static record and CNAME at the same time" <<
+       "Please fix your configuration for \"" << qdomain << "\", so that" <<
+       "it can be resolved by GeoIP backend directly."<< std::endl;
+    d_result.clear();
+    return;
+  }
+
   // we need this line since we otherwise claim to have NS records etc
   if (!(qtype == QType::ANY || qtype == QType::CNAME)) return;