From: Guido van Rossum <guido@python.org>
Date: Mon, 2 Oct 2000 15:53:08 +0000 (+0000)
Subject: Supporting rl_library_version is more trouble than it's worth --
X-Git-Tag: v2.0c1~164
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=1ea64ea3abf78a65f8145ab2613be7dfd178f4ce;p=python

Supporting rl_library_version is more trouble than it's worth --
readline doesn't have it before readline 2.2 and there's no
compile-time way to find out which readline version is in use.

Sigh.  GNU readline sucks.
---

diff --git a/Modules/readline.c b/Modules/readline.c
index 4105ddb2f7..cf0b064b64 100644
--- a/Modules/readline.c
+++ b/Modules/readline.c
@@ -38,7 +38,6 @@ extern int read_history(char *);
 extern int write_history(char *);
 extern int history_truncate_file(char *, int);
 extern Function *rl_event_hook;
-extern char *rl_library_version;
 #endif
 
 /* Pointers needed from outside (but not declared in a header file). */
@@ -495,16 +494,10 @@ static char doc_module[] =
 DL_EXPORT(void)
 initreadline(void)
 {
-	PyObject *m, *d, *v;
+	PyObject *m;
 
 	m = Py_InitModule4("readline", readline_methods, doc_module,
 			   (PyObject *)NULL, PYTHON_API_VERSION);
-
-	d = PyModule_GetDict(m);
-	v = PyString_FromString(rl_library_version);
-	PyDict_SetItemString(d, "library_version", v);
-	Py_XDECREF(v);
-
 	if (isatty(fileno(stdin))) {
 		PyOS_ReadlineFunctionPointer = call_readline;
 		setup_readline();