From: Matthew Fernandez Date: Sun, 25 Sep 2022 18:25:36 +0000 (-0700) Subject: Revert "smyrna: remove unused mAttributesSlot" X-Git-Tag: 6.0.2~28^2~4 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=1e1681862a3c74333b293e10b94eb8875e32b7a2;p=graphviz Revert "smyrna: remove unused mAttributesSlot" This reverts commit 37e430722d3981faf98b38259f320c3a36e6be4d. This function _is_ used (in share/gui/smyrna.glade). It is unclear why 37e430722d3981faf98b38259f320c3a36e6be4d claimed it was not. Gitlab: fixes #2279 Reported-by: Gagan Sidhu --- diff --git a/CHANGELOG.md b/CHANGELOG.md index 0ff141fe7..3c987de5f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -17,6 +17,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 handlers being not found have been fixed and the buttons to which they are wired should be functional again. This was a regression in 2.50.0 See #2279 for details. +- Smyrna warnings about the `mAttributesSlot` handler being not found have been + fixed and the button to which it is wired should be functional again. This was + a regression in 2.49.2 See #2279 for details. ## [6.0.1] – 2022-09-11 diff --git a/cmd/smyrna/gui/menucallbacks.c b/cmd/smyrna/gui/menucallbacks.c index cc6f22d65..0d49cd621 100644 --- a/cmd/smyrna/gui/menucallbacks.c +++ b/cmd/smyrna/gui/menucallbacks.c @@ -22,6 +22,11 @@ #include #include "frmobjectui.h" +void mAttributesSlot(GtkWidget * widget, gpointer user_data) +{ + showAttrsWidget(view->Topview); +} + void mOpenSlot(GtkWidget * widget, gpointer user_data) { (void)widget; diff --git a/cmd/smyrna/gui/menucallbacks.h b/cmd/smyrna/gui/menucallbacks.h index 16589b93f..af9600dc5 100644 --- a/cmd/smyrna/gui/menucallbacks.h +++ b/cmd/smyrna/gui/menucallbacks.h @@ -13,6 +13,7 @@ #include "gui.h" //file + _BB void mAttributesSlot(GtkWidget * widget, gpointer user_data); _BB void mOpenSlot(GtkWidget * widget, gpointer user_data); _BB void mSaveSlot(GtkWidget * widget, gpointer user_data); _BB void mSaveAsSlot(GtkWidget * widget, gpointer user_data);