From: Ilia Alshanetsky <iliaa@php.net>
Date: Sun, 12 Jul 2009 16:42:16 +0000 (+0000)
Subject: MFB: Fixed a possible crash inside OnUpdateErrorLog() when restoring an empty value
X-Git-Tag: php-5.2.11RC1~192
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=1e0340a4477116cdbf7b66518de1b54bac16965e;p=php

MFB: Fixed a possible crash inside OnUpdateErrorLog() when restoring an empty value
---

diff --git a/main/main.c b/main/main.c
index 7337abcb84..cfb8b531de 100644
--- a/main/main.c
+++ b/main/main.c
@@ -309,8 +309,7 @@ static PHP_INI_DISP(display_errors_mode)
 static PHP_INI_MH(OnUpdateErrorLog)
 {
 	/* Only do the safemode/open_basedir check at runtime */
-	if ((stage == PHP_INI_STAGE_RUNTIME || stage == PHP_INI_STAGE_HTACCESS) &&
-		strcmp(new_value, "syslog")) {
+	if ((stage == PHP_INI_STAGE_RUNTIME || stage == PHP_INI_STAGE_HTACCESS) && new_value && strcmp(new_value, "syslog")) {
 		if (PG(safe_mode) && (!php_checkuid(new_value, NULL, CHECKUID_CHECK_FILE_AND_DIR))) {
 			return FAILURE;
 		}