From: NAKAMURA Takumi <geek4civic@gmail.com>
Date: Sun, 27 Jan 2013 12:20:50 +0000 (+0000)
Subject: [CMake][Lit][unittests] Deprecate CMAKE_BUILD_TYPE in each build directory for unittests.
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=1df08370da6fb4578272295aabfacfb12e1d40f9;p=clang

[CMake][Lit][unittests] Deprecate CMAKE_BUILD_TYPE in each build directory for unittests.

For example,
cur) unittests/ADT/Release/ADTTests
new) unittests/ADT/ADTTests

RUNTIME_BUILD_MODE can be substituted to CMAKE_CFG_INTDIR.

With Make and Ninja, the tree is not built with multiple configurations.
Then, including the build type in target directory doesn't make sense.
See also "How can I build multiple modes without switching?"
http://www.cmake.org/Wiki/CMake_FAQ
CMAKE_CFG_INTDIR is set to "."

With multiple-configuration-aware build system, like Visual Studio, each unittest is built on appropriate directory, for example,
unittests/ADT/Release/ADTTests.exe
CMAKE_CFG_INTDIR is set to build system's variable, like "$(Configuration)" or "$(OutDir)".

Thus, "--param build_config" is also deprecated.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@173616 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt
index bce190f47a..b8bec6258f 100644
--- a/test/CMakeLists.txt
+++ b/test/CMakeLists.txt
@@ -73,8 +73,7 @@ else()
       COMMAND ${PYTHON_EXECUTABLE}
               ${LIT}
               --param clang_site_config=${CMAKE_CURRENT_BINARY_DIR}/lit.site.cfg
-              --param build_config=${CMAKE_CFG_INTDIR}
-              --param build_mode=${RUNTIME_BUILD_MODE}
+              --param build_mode=${CMAKE_CFG_INTDIR}
               ${LIT_ARGS}
               ${CMAKE_CURRENT_BINARY_DIR}
       COMMENT "Running Clang regression tests"