From: Boris Lytochkin <lytboris@php.net>
Date: Sun, 8 May 2011 09:20:58 +0000 (+0000)
Subject: fix error reporting on OID not increasing
X-Git-Tag: php-5.4.0alpha1~191^2~25
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=1dc02ac2def6ab6df932397f527029af721ff6c4;p=php

fix error reporting on OID not increasing
calling arguments markup
---

diff --git a/ext/snmp/snmp.c b/ext/snmp/snmp.c
index 7d7f16be96..a67839db19 100644
--- a/ext/snmp/snmp.c
+++ b/ext/snmp/snmp.c
@@ -837,10 +837,11 @@ retry:
 					/* OID increase check */
 					if (st & SNMP_CMD_WALK) {
 						if (snmp_oid_compare(name, name_length, vars->name, vars->name_length) >= 0) {
-							php_snmp_error(getThis(), NULL TSRMLS_CC, PHP_SNMP_ERRNO_OID_NOT_INCREASING, "Error: OID not increasing: %s", name);
+							snprint_objid(buf2, sizeof(buf2), vars->name, vars->name_length);
+							php_snmp_error(getThis(), NULL TSRMLS_CC, PHP_SNMP_ERRNO_OID_NOT_INCREASING, "Error: OID not increasing: %s", buf2);
 							keepwalking = 0;
 						} else {
-							memmove((char *)name, (char *)vars->name,vars->name_length * sizeof(oid));
+							memmove((char *)name, (char *)vars->name, vars->name_length * sizeof(oid));
 							name_length = vars->name_length;
 							keepwalking = 1;
 						}